Please offer only constructive criticism. The intent of the GD Showcase is to help the developer create the best game they possibly can. Show them you support their efforts when posting.
PennstateLion
Posted - 9/1/2005 12:08:15 PM
I posted the source code with the game, so please feel free to give me comments and suggestions on anything I could improve
First of all I would like to thank you for adding the source to the zip which made it that much easier for me to understand drawing 2D graphics with D3D!
Nice game impression over all, in my opinion the weakest part of the game is the music... Just a comment: when you rotate a block (holding the key down) the block falls much slower than usual. Maybe some time checking could come in handy?
To the code... It is a good idea to use some standard notation for the different variables. A minimum is to have some way of telling just by looking at the variable if it is a member variable of a class or a global variable or ... Just putting an underscore in front of all member variables is one way of doing this. The reason for doing this is of course readability. If someone else is going to delve into your code this makes their work much easier.
One more small note: for example in SetupBlocks you receive references to ints. Sometimes one needs to be careful with references. In this case i think the arguments should be either const references or passed by value. Just so the function SetupBlocks don't alter the values of StartX and startY, respectively.
Well, all in all, a good first game, and I felt obliged to rate you for being helpful btw, because of you helping me from going mad when you attached the source code.